Jump to content
XCOMUFO & Xenocide

Api Changes


gangsta

Recommended Posts

Ok from now on I'll post these kinda things to the mailing list but I am working on CVS tonight. Anyway, I was commenting code when I came across these incorrectly named methods in the xenocide::datastorage::Base class.

 

getSoldiersPIN()

getEngnieersPIN()

getScientistPIN()

 

all these functions return a list of PINs to the calling function so the changed names are

 

getSoldierPINs()

getEngnieerPINs()

getScientistPINs()

 

This gives each function the correct meaning in english now.

Link to comment
Share on other sites

Ok from now on I'll post these kinda things to the mailing list but I am working on CVS tonight.  Anyway, I was commenting code when I came across these incorrectly named methods in the xenocide::datastorage::Base class.

 

getSoldiersPIN()

getEngnieersPIN()

getScientistPIN()

 

all these functions return a list of PINs to the calling function so the changed names are

 

getSoldierPINs()

getEngnieerPINs()

getScientistPINs()

 

This gives each function the correct meaning in english now.

getSoldierPINs () suggest me about a soldier with multiple PINs, maybe its my poor english...

 

getSoldiersPINs () suggest me about getting the PINs from the soldiers (semanticly not good, given the fact that every soldier have a unique Personal Identification Number).

 

getSoldiersPIN () suggest me about getting the Personal Identification Number of all the soldiers. (That's the semantic idea of the method anyway).

 

Greetings

Red Knight

Link to comment
Share on other sites

we can do getSoldiersPINs() too it probably would be better. but getSoldierPINs() can work too and means to get PINs of type Soldier. Either way it is important to have PINs in plural form to show you getting a list of PINs instead of just one. I'll change to the former since it is more specific. :)
Link to comment
Share on other sites

we can do getSoldiersPINs() too it probably would be better.  but getSoldierPINs() can work too and means to get PINs of type Soldier.  Either way it is important to have PINs in plural form to show you getting a list of PINs instead of just one.  I'll change to the former since it is more specific. :)

Ok then...

 

Greetings

Red Knight

Link to comment
Share on other sites

×
×
  • Create New...