Jump to content


Photo

Crc Errors, Nid Errors And A Desynchronized Game


  • Please log in to reply
11 replies to this topic

#1 uff

uff

    Sergeant

  • Forum Members
  • PipPipPip
  • 14 posts

Posted 19 September 2007 - 02:23 AM

Hi,

I was trying to get an account on Mantis to add a comment to a bug but I am now waiting for more than 24 hours and no register email came to me.
Is there something wrong with the Mantis or should I wait more ?

uff

Edited by Serge, 21 September 2007 - 04:08 AM.


#2 Guest_Azrael Strife_*

Guest_Azrael Strife_*
  • Guests

Posted 19 September 2007 - 11:30 AM

Something wrong with Mantis.

#3 uff

uff

    Sergeant

  • Forum Members
  • PipPipPip
  • 14 posts

Posted 19 September 2007 - 01:44 PM

Something wrong with Mantis.

Oh, not cool.
Anyway this may be later removed by a moderator, considers bug 250, crc errors and such stuff.
As Serge wrote, such errors may be caused by wrong floating point calculations.
While browsing through main.cpp, there is a routine, init_fpu(), which sets a bool variable, fpu_is_ok.
The variable is only used once, when a player clicks "connect to internet server" from main menu in the game.
However, when a player starts a hot seat game or connects to an internet server by providing login and password in command line
the fpu check is not performed.
So now why the double standard ? Or is the init_fpu() routine obsolete and outdated ?

Thanks for an answer,

#4 Serge

Serge

    Project Leader: UFO 2000

  • Xenocide Programming Department
  • 785 posts

Posted 19 September 2007 - 04:09 PM

Something wrong with Mantis.

Oh, not cool.
Anyway this may be later removed by a moderator, considers bug 250, crc errors and such stuff.
As Serge wrote, such errors may be caused by wrong floating point calculations.
While browsing through main.cpp, there is a routine, init_fpu(), which sets a bool variable, fpu_is_ok.
The variable is only used once, when a player clicks "connect to internet server" from main menu in the game.
However, when a player starts a hot seat game or connects to an internet server by providing login and password in command line
the fpu check is not performed.
So now why the double standard ? Or is the init_fpu() routine obsolete and outdated ?

Thanks for an answer,

You can check http://ufo2000.svn.s...0/trunk/HACKING and search for "floating point" to find an explanation. Hotseat is not affected as everything is calculated on the same machine in that case. Missing floating point consistency check when connecting to the server by using just command line arguments is a bug.

Anyway, on desktop PC's, this check would almost always pass unless something is terribly miscompiled.
ufo2000 development team
http://ufo2000.sourceforge.net

#5 uff

uff

    Sergeant

  • Forum Members
  • PipPipPip
  • 14 posts

Posted 20 September 2007 - 02:13 AM

You can check http://ufo2000.svn.s...0/trunk/HACKING and search for "floating point" to find an explanation. Hotseat is not affected as everything is calculated on the same machine in that case. Missing floating point consistency check when connecting to the server by using just command line arguments is a bug.

Thanks for the answer.
Sure, I read the HACKING file.
Sadly, the link provided there, in floating point section, is outdated.

#6 Serge

Serge

    Project Leader: UFO 2000

  • Xenocide Programming Department
  • 785 posts

Posted 20 September 2007 - 02:25 PM

Thanks for the answer.
Sure, I read the HACKING file.
Sadly, the link provided there, in floating point section, is outdated.

googling for "goldberg1.doc" lets us find the same information on a different server quite fast: http://www.litho.uca...dberg1.doc.html
ufo2000 development team
http://ufo2000.sourceforge.net

#7 bamb

bamb

    Captain

  • Forum Members
  • PipPipPipPip
  • 155 posts

Posted 20 September 2007 - 06:37 PM

Any ideas why the game uses so much memory? Especially the equip screen seems to be hungry...

#8 uff

uff

    Sergeant

  • Forum Members
  • PipPipPip
  • 14 posts

Posted 21 September 2007 - 02:01 AM

googling for "goldberg1.doc" lets us find the same information on a different server quite fast: http://www.litho.uca...dberg1.doc.html

Ah yes, crap, didn't occur to me to google it this way. Thanks for the pointer.

#9 uff

uff

    Sergeant

  • Forum Members
  • PipPipPip
  • 14 posts

Posted 23 September 2007 - 05:11 AM

Missing floating point consistency check when connecting to the server by using just command line arguments is a bug.

As I can not post on Mantis, I attach the patch file here. It is a small one so easy to check

Attached Files

  • Attached File  main.rar   567bytes   144 downloads


#10 nachtwolf

nachtwolf

    UFO2000 Staff: Leader

  • Moderators
  • PipPipPipPip
  • 310 posts

Posted 27 September 2007 - 05:04 PM

Missing floating point consistency check when connecting to the server by using just command line arguments is a bug.

As I can not post on Mantis, I attach the patch file here. It is a small one so easy to check


Thanks a lot, I'll review it as soon as I get some spare time. ( ETA 2 weeks)

Edited by nachtwolf, 27 September 2007 - 05:08 PM.

Posted Image

#11 uff

uff

    Sergeant

  • Forum Members
  • PipPipPip
  • 14 posts

Posted 28 September 2007 - 02:23 AM

Thanks a lot, I'll review it as soon as I get some spare time. ( ETA 2 weeks)

No problem, now I am looking into the credits feature, Mantis no. 542.
So far I added a button in the main menu, just before quit button.
Now, where to read the credits from ? The AUTHORS file ?
My current approach is just to read the file line by line and display in a window.
I will just have to figure out how to do a "floating text" window.
Any other suggestions ?

#12 uff

uff

    Sergeant

  • Forum Members
  • PipPipPip
  • 14 posts

Posted 03 October 2007 - 01:25 PM

No problem, now I am looking into the credits feature, Mantis no. 542.

Ok I did the credits stuff.
Added a button in main menu.
Did the flowing credits from the AUTHORS file, they are drawn on menu.jpg

There is one small glitch though, when I press a key to get back to the main menu, a small part (1cm x 0.5 cm) of menu.jpg stays where the cursor is placed. When I enter tip of day or options and then return back to main menu again, it is clear and dandy. Maybe some refresh stuff ?
I do not know how to handle this. But nevertheless it does not break anything.

Attached Files